-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Add missing WORKER_SELF_REFERENCE service binding to wrangler configuation
#8589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing WORKER_SELF_REFERENCE service binding to wrangler configuation
#8589
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8589 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 103 103
Lines 9036 9037 +1
Branches 311 311
=======================================
+ Hits 6778 6779 +1
Misses 2256 2256
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the missing WORKER_SELF_REFERENCE service binding to the Wrangler configuration file, which is required by OpenNext for caching functionality as documented in the OpenNext Cloudflare documentation.
Changes:
- Added
servicesarray withWORKER_SELF_REFERENCEbinding pointing to thenodejs-websiteworker
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
flakey5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
requesting fast track |
Description
As per the open-next docs, in the wrangler configuration there should be a
WORKER_SELF_REFERENCEservice binding (that is used by open-next for caching): https://opennext.js.org/cloudflare/get-started#3-create-a-wrangler-configuration-fileThis PR is adding this service binding to the wrangler configuration since it is currently missing
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.